Repository navigation
fix: align DuckDB and PostgreSQL type inference with engine results - #27
Merged
Merged
Conversation
Record DuckDB 1.5.2 and PostgreSQL 17 result types for a synthetic expression matrix and replay them in tests. Add per-engine rules for arithmetic (DuckDB `/` is DOUBLE, `//` parses as integer division), literals, aggregates, CASE/COALESCE/NULLIF unification, date/time arithmetic, casts and common scalar functions, returning no type where the engine result is not modelled. Parse bare USER as the niladic function in dialects that define it and register DuckDB's keyword time functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DuckDB and PostgreSQL result types were never verified against the real engines, and many inferred types were wrong. For example, DuckDB
/returns DOUBLE for every integer and decimal pair, but was inferred as an integer type. Downstream tools that compare inferred types with warehouse columns reported false schema changes as a result. Some DuckDB keyword functions (CURRENT_TIMESTAMPand others) and bareUSERwere also reported as unknown.Changes
//parses as integer division. BareUSERparses as the niladic function where the dialect defines it. DuckDB keyword time functions are registered.Verification
make fmt-check,lint-rust(Rust 1.98),check-consistency,extract-all-fixtures, all fourtest-rust-ci-*targets andtest-python, all green.