Repository navigation
feat(native): build compile attachments natively behind the preview engine - #1018
Merged
Merged
Conversation
…hind the preview engine
…the preview engine
… the preview engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
M3g moves the compile attachments (everything that is not a model) onto the native path behind the
native-previewengine, so the preview compile keeps closing the gap to an all-native compile. Output must stay byte-identical to Python or defer to it.Changes
NativeStage.ATTACHMENTS(preview tier) and asqlbuild-attachmentscrate.$keeps Python interpolation so unclosed dollar quotes raise Python's message.${...}templates expand natively, recording the same environment reads. A native rejection Python accepts raisesNativeStageMismatchError.@namerendering, severity and run scope. Conflicts, unknown values, odd argument types and non-ASCII whitespace defer to Python.source_template,function_header_templaterender kinds).Verification
cargo test --workspace, clippy and fmt (1.98.0)make compiler-differentialwith stage captures and full coverage: 168/168;make compiler-differential-shipped: 162/162tests/e2e/scripts/compiler_differential: 18 passedmake check-ci,make test(11701 passed), hygiene scan