Repository navigation
ci: generate release baseline benchmarks with the baseline environment - #1021
Merged
Merged
Conversation
The release comparison ran the previous release's benchmark generator with the head interpreter and only the baseline source on PYTHONPATH, so the generator imported the head sqlbuild package and failed once head removed a symbol the baseline still imports. Put the baseline environment's package directories ahead of the head packages so sqlbuild and its native dependencies resolve to the baseline install, and require the baseline environment to use the same Python minor version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release PR's "Compare with the previous release" job failed before measuring: the previous release's benchmark generator ran with the head interpreter and only the baseline source on
PYTHONPATH, so it imported the headsqlbuildpackage. Once head removed a constant the baseline generator still imports, generation failed withImportError. The compile ratio guard had already been fixed for the same class of bug.Changes
PYTHONPATHafter the baseline source and ahead of the head packages, sosqlbuild, its native module and its runtime dependencies resolve to the baseline install. The head interpreter still supplies test-only generator dependencies (pytest) that the baseline runtime environment lacks. Applies to both the pristine and dense baseline generators.Verification
sqlbuildsymbol absent from this checkout succeeds (pristine and dense); both fail without the fix.sqlbuild,polyglot_sql,duckdbandscriptsresolve to the baseline install/source.make check-ci, focused release/compile performance tests, public-repository scan.