Repository navigation
feat(native): register the analysis stages behind the preview engine - #1024
Merged
Merged
Conversation
kvlonge
force-pushed
the
feat/native-analysis-seams
branch
from
October 8, 2026 07:32
e29893f to
a5f1799
Compare
…eams Route the per-model dynamic pivot proof through the model-analysis dispatch: ModelSqlAnalysis gains an optional dynamic column contract proof that replaces the Python proof when the native analysis supplies one, and the native analysis request now carries the dynamic families. Infer expression-source shapes through a MODEL_ANALYSIS stub and assemble compiled SQL test facts through a SQL_TEST_GLUE stub, each gated once per compile, so the M4d and M4h lanes no longer need to edit project.py. Drop the vacuous native type normalization test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The native analysis work is split into parallel lanes that all need entries in the same shared files. Registering every lane once here lets each later lane touch only its own files.
Changes
NativeStagemembers andpreviewtiers forTYPE_SYSTEM,MODEL_ANALYSIS,SEMANTIC_CHECKS,CONTRACTS,LINEAGE_FACTS,SQL_TEST_GLUEandPROJECT_ASSEMBLY.None-returning ("use Python") stub per seam, each gated once per compile. Dispatch lives incompile/_helpers/native_stages/(project assembly, model analysis, expression-source shapes, SQL test assembly) and at semantic completion, contracts, fast lineage and SQL test planning.ModelSqlAnalysisgains an optional dynamic column contract proof; a native analysis that carries one replaces the per-model Python pivot proof. The native analysis request also carries the dynamic families.registerfunctions, emptysqlbuild-analysismodules, labelled_native.pyisections, and anative_sessionfield onCompiledProject(omitted from stage captures).assembly/semantic_shapes.pysoproject.pystays under the fensu cap.No behaviour change: under every engine the stubs return
Noneand Python runs as before.Verification
python,nativeandnative-preview. Under preview every seam is called exactly once and returnsNone; under the others none is called. Reports and compiled artifacts are byte-identical across engines.cargo test --workspace --all-features, clippy, fmt,make check-ci,make test,make compiler-differential(CI flags),make compiler-differential-shipped,tests/e2e/scripts/compiler_differential.