Repository navigation
feat(native): build fast column lineage natively behind the preview engine - #1029
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
FAST column lineage still ran in Python and called the Polyglot wheel's
parse_onefor each model without compact facts, such as models withsql_analysis false. This PR builds the same lineage natively undernative-preview. Thepythonandnativeengines are unchanged.Changes
sqlbuild-analysis::lineage: star expansion and the parse fallback, using the crate parser. It ports the reference matching, alias maps, confidence and transform rules, union branches, and the pythonize-shapedto_dictwalk.UNION ALLchains stay linear in cost and depth.{"kind","site"}deferral, when:build_fast_column_lineagebinding and stub, plus lineage failure-corpus cases.Verification
compile --jsonandlineage --mode fast, including a 480-branchUNION ALLbeside a second opted-out model. That project segfaulted before this fix.cargo test --workspace --all-features, clippy and fmt 1.99.0,make compiler-differentialwith CI flags (fast_columns wheel calls 204 to 0, no deferrals),-shipped,make test,make check-ciand the hygiene scan all pass.