Repository navigation
feat(native): build model config and validate models natively behind the preview engine - #1034
Merged
Merged
Conversation
…the preview engine
…n names to Python
kvlonge
enabled auto-merge (squash)
October 8, 2026 14:55
kvlonge
force-pushed
the
feat/native-model-loop-leftovers
branch
from
October 8, 2026 14:55
88a5dd2 to
abbc715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
M3i (native rendering as the default) needs the per-model loop's config work to run natively. After M3e/M3f the preview engine still built model config and ran the model config validators in Python for every model.
Changes
sqlbuild-model-config: native path-default selection, Python-exactDuration/ISO cursor-bound parsing, header storage overrides, and the happy path of all ten model validators (references, incremental/microbatch, capability, contract, non-incremental, snapshot, custom materialization, storage, migration, placeholders). Anything uncertain (non-ASCII text, unusual ISO forms, big ints, odd types) rejects.NativeModelConfigBuilderlayers defaults, path defaults and headers, expands${...}templates, applies target namespace overrides and storage policies, and returns the reads Python records;NativeModelValidatoraccepts or rejects.MODEL_CONFIGstage: the loop uses both. A deferred build runsbuild_model_config; a rejection runs the Python validators for the exact error. Shipped/python engines unchanged.run_python_model_validators(same order).Verification
cargo test --workspace --all-features; clippy/fmt 1.99.0.make compiler-differential(CI flags): 243/243;-shipped: 237/237.tests/e2e/scripts/compiler_differential,make check-ci,make test(11,833 passed), hygiene scan.