Repository navigation
feat(native): report attachment errors natively - #1038
Merged
Merged
Conversation
kvlonge
force-pushed
the
feat/native-attachment-errors
branch
from
October 8, 2026 17:53
47bc863 to
101e9d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Under
native-preview, the attachments stage returned nothing on invalid input, so Python attached it again just to raise its own error.Changes
Native code now raises Python's exact P001 error at the same point. Unsupported inputs still defer to Python.
${...}errors in sources and functions; model config unchanged.@param: malformed or undeclared references and unclosed text.@@var: unknown variables and unclosed text. As in Python, only'and"double, so doubled backticks end one segment and start another.Bridge rule: an error skips the re-run only if neither its text nor whether it fires depends on macro-expanded SQL. Marked
bridge_independent=True:@param: raw test body@@var: authored SQL, before macrosNot marked: cursor intrinsics, which are checked on macro-expanded SQL. The re-run stays until slice 2.
Verification
cargo test --workspace --all-features, clippy and fmt (1.99.0)substitute_sql_vars; 30k backtick fuzz: no mismatches.error_typeCompileInputError, macros once (cursor intrinsic: twice under preview).make compiler-differential(CI flags, 260 identical),-shipped(254),tests/e2e/scripts/compiler_differential,make check-ci, hygiene