Repository navigation
fix(rename): suggest the one-step sqb mv command when a rename crosses layers - #1048
Merged
Merged
Conversation
kvlonge
enabled auto-merge (squash)
October 9, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CHI-561: when
sqb renamegives a model a name from another layer (for exampleint_cleantoint_enriched), the file stays in its folder and verification fails the layer-folder rules (SQBRPROJECT102/105). The output only listed the rule failures, so it looked as if SQLBuild could not rename and move in one step, althoughsqb mvwith a.sqldestination already does.Changes
sqb mv <old> <path>.sql. The path swaps the folder of the model's current layer for the new layer's folder and keeps the folders around it.--project-diris repeated when given, quoting follows the platform's shell, and the note says to change the folder if wanted.models/<folder>/<new_name>.sql.sqb renamestill never moves files. No layer setting is involved, so no TOML hint.Verification
make check-ci, public-repository scan.