Repository navigation
feat(native): run semantic checks natively behind the preview engine - #1050
Merged
Merged
Conversation
kvlonge
enabled auto-merge (squash)
October 9, 2026 00:22
…checks # Conflicts: # tests/e2e/scripts/compiler_differential/test_compiler_differential.py # tests/e2e/src/sqlbuild/cli/commands/main/compile/test_native_analysis_seams.py
…cks CLI test Model analysis now records its own preview deferrals, so the semantic checks test filters to its stage's sites.
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Semantic completion runs after model analysis. It recovers output types for failed models, adds B002 recovery notes, explains diagnostics and rejects unneeded
sql_analysis falseopt-outs. It still runs in Python and calls the Polyglot wheel to tokenize and parse failed models. This is the first part of moving the stage natively behind thenative-previewengine.Changes
sqlbuild-analysis::semantic_checksports:CompiledProjectand applies the result. Shape publication and the binding-catalog revalidation stay Python inputs.metadata_checksdeferrals. A follow-up PR ports them.pythonandnativeengines are unchanged.Verification
make compiler-differentialwith CI flags passes: 281 projects identical, analysis coverage 56/56, wheel sites feat: add shared type normalization #8 and Feat/databricks adapter #9 at 0 under previewmake compiler-differential-shipped,tests/e2e/scripts/compiler_differential,cargo test --workspace --all-features, clippy and fmt on 1.99.0,make check-ci,make test, hygiene scan