Repository navigation
feat(native): run metadata checks natively behind the preview engine - #1058
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Under
native-preview, semantic metadata checks still ran in Python, and B102/B301 UDF checks parsed models with the Polyglot wheel. This finishes the native semantic-checks stage.Changes
cursor_inputs) and B301 cursor types; B300 sourcecursor_column; B302 SQL-test columns; Python's positionsexpression_is_true,relationships,accepted_valuesaudits and resource SQL checks. No Python is deleted: thepythonengine and the fallback still use the metadata path_helpers/regrouped into four folders (pure move)test_native_semantic_checks_cli.py: its module name clashed with the integration file, dropping tests in combined runsChanged expectations:
metadata_checks metadata_validation.py, which no longer occurs.input_enrichment analysis_sessionstaysSEMANTIC_CHECKSno higher thanTYPE_SYSTEMVerification
make compiler-differential(CI flags): 307 identical, coverage 56/56, no semantic deferrals, semantic wheel sites 0tests/e2e/scripts/compiler_differential: 300 passedcargo test --workspace, clippy/fmt 1.99.0,make check-ci,make test, hygiene