Repository navigation
ci: run required checks for the merge queue - #1061
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainis moving to a merge queue: exact-count gates break when two pull requests merge on green runs against an outdatedmain. The queue only merges once every required check (Verify,Pull Request Metadata,Block automatic 1.0 releases) reports on themerge_groupevent, so each workflow behind them needs that trigger first.Changes
verify.yml: runs onmerge_group. The classifier scopes from the group'sbase_sha...head_sha, which covers every queued pull request in the group. A missing SHA or failed diff runs every suite instead of skipping. Concurrency keys on the queue ref and never cancels merge-group runs. The same-runner ratio compares against the group base.pull-request-metadata.yml: runs onmerge_groupand succeeds, since the queue only admits pull requests whose metadata check passed. It runs rather than skips so the required check always reports.version-guard.yml: runs onmerge_groupagainst the group head, so the version that would land onmainis the one checked.merge_groupchecks.No test expectations or thresholds change.
Verification
actionlint1.7.7 on the three workflowsmerge_groupevents (code diff, docs-only diff, missing and unknown base SHA), pluspull_requestandworkflow_dispatch: scopes match the PR path, and diff failures run every suitemake check-ci, hygiene scan