Repository navigation
Conversation
…tion A seeded differential compares native CTE fact recovery with Python's over 5,000 queries and adapter profiles through a test-only oracle binding. The model-analysis CTE recovery count is relabelled as a corpus floor over Python's reference run.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 9, 2026
Contributor
Author
|
Landed together in #1075 to cut merge-queue CI runs; review history stays here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native enrichment sent CTE fact recovery for contract models back to Python. Under preview those deferrals are now 0.
Changes
_polyglot_cte_passthrough_factsand filtered non-null outputs (cte_facts.rs); adapter nullability rules passed to native._oracle_cte_fact_recovery(existing_oracle_*pattern).legacy_analysis, 1input_enrichmentdeferrals (same on main).Test expectation changes
python_cte_recoveries ≥40, a corpus floor (deterministic 40). Native proof: 0input_enrichmentdeferrals (max 120 -> 0) and no mismatches. Native-model minimum also subtracts enrichment deferrals.test_native_cte_fact_recovery.py: native vs Python recovery over 5,000 seeded queries, adapter profiles (duckdb, snowflake, bigquery, databricks, postgres, tsql, generic, None). The end-to-end test misses most differences (enrichment output only fills untyped columns), and no file compares the functions. Deterministic floors: 4,319 compared, recovered types 1,243, nullability 417, direct 859, non-null 38; 681 non-ASCII deferrals.if_func, whose arguments Python never collects, so adapters' IF/IFF rules are unknown on both sides. A synthetic kind-keyed profile reachesconditional_result/first_arg.Verification
conditional_resultandfirst_argeach fail the differential (2 and 3 mismatches). Forcing native recovery to defer fails the parity gate (68 <= 0).cargo test -p sqlbuild-analysis, clippy/fmt 1.99.0, parity files,make check-ci,make test, hygiene. Earlier: differential (319 identical), seam/differential E2E.