Repository navigation
Conversation
kvlonge
enabled auto-merge
October 9, 2026 11:27
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 9, 2026
kvlonge
enabled auto-merge
October 9, 2026 15:43
kvlonge
force-pushed
the
feat/native-sql-test-assembly
branch
from
October 9, 2026 16:42
2fb9252 to
194b280
Compare
Contributor
Author
|
Landed together in #1075 to cut merge-queue CI runs; review history stays here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Under preview, SQL tests were still assembled in Python. This builds their facts natively and hands back only what it cannot match exactly.
Changes
sqlbuild-analysis: native assembly of test names, target models, scope deps (incl. the macro call scan), case fingerprints (withDecimal.normalize) and P013 mock-reads-referencing-helper diagnostics with locations.assemble_compiled_sql_testsreads compile inputs directly;SQL_TEST_GLUEassembles natively and reports diagnostics in Python's order.macro_mocks(29)._assemble_compiled_sql_test, still used by thepythonandnativeengines.Verification
testE2E (186 passed);make compiler-differentialCI flags (321 identical);cargo test --workspace, clippy/fmt 1.99.0;make check-ci;make test(11940 passed); hygiene.Test expectation changes
assemble_native_sql_testsexpectedNone, now native assemblies (none deferred): the seam answers.macro_mocks4,non_ascii_text11,decimal_context5. Any other deferral kind fails.