Repository navigation
feat(native): run pivot proofs, opt-out checks and semantic completion through the native session - #1067
Closed
kvlonge wants to merge 3 commits into
Closed
feat(native): run pivot proofs, opt-out checks and semantic completion through the native session#1067kvlonge wants to merge 3 commits into
kvlonge wants to merge 3 commits into
Conversation
…rough the native session The finished analysis session is kept on CompiledProject.native_session and proves pivot models outside it from its own tables; without a session one batched standalone call sends the tables once. The per-model native proof path is deleted. SQL-analysis opt-out syntax checks use the native checker under the preview engine. Rule hosts drop the session before pickling.
…t and gate on session proofs
kvlonge
force-pushed
the
feat/native-project-session
branch
from
October 9, 2026 16:06
95d26f8 to
c51b7c4
Compare
kvlonge
enabled auto-merge
October 9, 2026 16:06
…sion Type recovery and completion read each analysed model's output names and lineage from the finished native session instead of payload rows rebuilt from CompiledProject. Models whose analysis Python answered, failed, or whose names a dynamic pivot proof replaced keep the payload.
kvlonge
changed the title
kvlonge
disabled auto-merge
October 9, 2026 16:46
kvlonge
enabled auto-merge
October 9, 2026 16:56
Contributor
Author
|
Landed together in #1075 to cut merge-queue CI runs; review history stays here. |
github-merge-queue
Bot
removed this pull request from the merge queue due to a manual request
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
M4i parts 2 and 3. Under
native-preview, pivot proofs, opt-out syntax checks and semantic completion's model facts come from the finished native analysis session.Changes
finishreturns aFinishedSession(pivot tables, pool, model facts), passed as an argument, never stored onCompiledProject.check_native_sql_syntax. Panicking proofs and unrejected opt-outs defer. Deleted as dead on every tier: the per-model proof binding,prove_dynamic_contract.rs,_prove_native_dynamic_contract.py,_helpers/dynamic_contract.py.lineage_payloadstill feeds the rest).test_native_analysis_seams: analysis returnsNativeModelAnalyseswith a session.StandalonePivotProofTestCasegainsexpected_session_proofs; new no-analysis case.semantic-recovered-uses-through-intermediate(321→322).SemanticInputsgainsnative_session.Verification
make check-ci, hygiene.