Repository navigation
perf: skip redundant SQL normalisation and CTE scans during compile - #1088
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Profiling a generated 10,000-model project showed compile work that does not change output: every analysis-cache hit normalised its SQL eagerly although only a few readers need it, and SQL-test planning re-tokenised the same model SQL for every test and comparison body (about 7% of instructions on a 1,000-model cold compile).
Changes
outcome_rows, binding-diagnostic locations) through a newresolved_cleaned_sql.defined_cte_keysskips tokenising text without the keywordwithand returns a plain list (every caller treated "unscannable" as empty).Verification
mainfor cold and edit compiles on a 1,000-model generated project and a private real project (compile only).compiler-differentialwith stage captures and coverage gates: 368 projects as expected.cargo test -p sqlbuild-analysis, clippy and fmt (stable); focused pytest on SQL-test planning, cache invalidation, binding catalog, native model analysis and the new test;make test;make check-ci.