Repository navigation
refactor: move discovery validation and YAML parsing to Rust - #1091
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
First milestone of the Rust-hosted compile (CHI-589): move discovery logic out of Python. Each port deletes the Python it replaces and keeps behaviour identical, including error text, exception classes and which error is reported first.
Changes
sqlbuild._native.DiscoveredSqlModelFile) built directly by native discovery; the model loop reads them without Python unpacking. Records still copy, pickle and support lint-fix edits.sqlbuild-discovery::project_validation. The seed header reader matches Python'scsvreader; the running interpreter still judges CSV dialect settings, so 3.13/3.14 errors are unchanged.sqlbuild-discovery::yaml_entries.strip,casefold,isalnum,isdigitandisspacehelpers insqlbuild-core.Verification
mainon a generated 1k-model project and a private project (cold and edit).main.make test,make check-ci, one review plus a follow-up pass.