Repository navigation
refactor: move compile-input preparation to Rust - #1092
Merged
Merged
Conversation
…hema attachment checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Phase 1 of the Rust-hosted migration moves compiler logic into Rust and deletes the Python it replaces. This milestone covers the compile-input stage: preparing each model before the native model loop, plus the public declaration indexes, required column reads, and default layering that sit around it.
Changes
@@interpolation and declaration scans itself, builds the known resource names from the discovered inputs, and indexes SQL hook definitions.extendsresolution, cycle and override errors) are built in Rust.schema.ymlmodel-entry attachment checks (discovery always rejectsmodels:content), plus dead compiler Python.extendserrors. Each golden is added for a new case; no existing goldens change.Movable Python: 143,789 → 141,910 lines.
Verification
mainon a 1k-model project and a real project, both cold and after an edit.make test(11,572 passed),make check-ci, and the public-repository scan all pass.