Repository navigation
ci: smoke test the published wheel through the current native catalogue entry point - #1131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Publishing 0.157.0 fails in the Linux x86_64 wheel smoke test. It calls
sqlbuild._native.catalogue_json(), which an earlier refactor removed. The smoke test only runs during Publish, so nothing caught it before the release.Changes
sqlbuild._native.semantic_help_catalogue(), the current native catalogue entry point.Verification
semantic_help_catalogue()returns a non-empty catalogue on a build of the release tree.sqb --version,--help, andscopeon a one-model project, in JSON and text) pass locally against the same build.