Repository navigation
perf: write the custom-rule host payload natively and decode facts lazily - #1135
Merged
Merged
Conversation
…zily Custom-rule hosts received the whole compiled project as Python records pickled on the compiling thread, then unpickled every value before running any rule. The payload is now written by native code: model names, paths, keys, SQL text, config values, inferred columns and natively parsed header columns are stored without building Python objects, and only values that Python alone holds are pickled one by one. The host reads the header and decodes each fact the first time a rule reads it, so a rule touching one fact per model decodes only that fact. Fact views read the host project through narrow protocols; collections and declarations are read on first access. Read recording, cache keys and the host process lifecycle are unchanged.
…e native payload Rules reading every public fact report the compiled values cold and warm and rerun only the edited model's invocation; failing, host-exiting and slow rules keep their results, messages and payload cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Custom rules spent most of their time preparing data rather than evaluating rules: the main process built Python records for the whole project and pickled them into one payload before the host could start (about 3 s of main-thread work on the dense 10k project).
Changes
Verification