Repository navigation
fix: keep SQLite loader and source timestamps as text and add a waffle shop E2E - #1154
Merged
Merged
Conversation
…affle shop E2E SQLite's CAST to a date or time type keeps only the leading number, so loader rows and declared TIMESTAMP/DATE source columns were stored and read as 2026. Loader rows are now written uncast with their types declared on the staging table, Python datetimes are written as canonical UTC text, and date/time source, contract and retype casts keep the stored text. Tables copied from untyped columns no longer gain a BLOB type that later reads as a type change. Adds a waffle shop build, test and rebuild E2E on SQLite whose row counts match a DuckDB run, plus focused loader and adapter tests.
kvlonge
enabled auto-merge (squash)
October 19, 2026 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running the waffle shop project on SQLite showed that SQLite's
CAST(x AS TIMESTAMP)andAS DATEkeep only the leading number: loader timestamps were stored as2026, declared date/time source columns read the same way, and copied untyped columns gained aBLOBtype that the next build reported as a type change.Changes
Verification