Repository navigation
Conversation
kvlonge
enabled auto-merge (squash)
October 19, 2026 21:59
Contributor
Author
|
Closing in favour of one combined PR (H2 + fensu 0.27 + SharedMergeTree on top of the merged deadlock fix) so these share a single CI run; the branch is being fixed for an interaction between H2's broken-pipe parity tests and the merged changes. |
auto-merge was automatically disabled
October 19, 2026 23:21
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
fensu 0.27 enforces small tuples (FPRSS012), crate layout (FPRSR311) and Python dead-code detection. Upgrading keeps the structure checks current and removes code nothing reaches.
Changes
Bump fensu to 0.27.
Replace every tuple over three elements with a named struct. Rows that cross into Python use a shared
positional_record!/positional_fields!helper, so Python sends and receives the same tuples as before.Move the Snowflake function list under
sqlbuild-analysis/src; allowpyproject.tomlin crate roots.Enable
[targets.python.dead_code]and remove dead code (~350 lines):CaptureFile(its text helper is kept), policy constantsRoots for code reached by mechanisms fensu cannot see:
_native_hosttargets and built-in adapter classespython -mscript entry points and fensu rule modules_native.pyiA test keeps the host roots in sync with the host table.
Raise the XSB073 budgets: a named struct's Python fields are now counted, where tuple positions were not.
Verification
fensu check: 0 faults (164 before, on 0.27).make compiler-differentialpasses; goldens unchanged.cargo teston the touched crates pass.make test: 11750 passed. One wall-time budget test failed under load and passes on its own.make check-cipasses via verify; hygiene scan is clean.