Repository navigation
perf: build the sqb binary and the extension from one set of compiled dependencies - #1179
Merged
Merged
Conversation
The sqb build resolved several dependency features differently from the extension build, so Cargo compiled polyglot-sql, sqlbuild-analysis, sqlbuild-rules and their dependencies twice in every wheel and uv sync. A new code-free sqlbuild-build-features crate enables the missing features in the sqb build, and make check-build-features fails when the two builds drift apart again.
kvlonge
enabled auto-merge (squash)
October 20, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
sqbbinary and the extension resolved shared dependencies with different features, so every wheel build and everyuv synccompiled polyglot-sql, sqlbuild-analysis, sqlbuild-rules and 34 other crates twice. On macOS, maturin's link flags for the extension forced a full second build as well.Changes
sqlbuild-build-featurescrate (no code) thatsqlbuild-clidepends on to enable the features the extension build already resolves, for normal and build dependencies.make check-build-features, run bymake check-ci, compares both builds' resolved features withcargo treeon all five wheel targets and names any drift.-undefined dynamic_lookuplink flags to thesqbbuild so it reuses the same compiled crates; the wheel smoke test still runssqbandsqlbuild.Verification
sqb: 37 recompiled units before, 1 (sqlbuild-cli) after.sqbsize unchanged (6.37 MB).sqbstep: Linux 499 s -> 42 s, Windows 629 s -> 7 s, macOS 617–1,265 s -> 4–16 s.make check-ci, entry/parity tests, compiler differential 373/373,cargo testfor the touched crates.