Repository navigation
fix: speed up clone preparation and keep its console output clean - #1180
Merged
Merged
Conversation
… keep library logs off the console
…timing, failed phase messages
…flag, reuse the spinner thread
kvlonge
enabled auto-merge (squash)
October 20, 2026 15:35
Records logged from outside the project now count as library output, so the user family in the stdout-purity test comes from a module inside the test project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sqb clonespent most of its time preparing (two to four full compiles with SQL analysis, every source inspected twice), its finished spinner redrew over clone output, and library logs (INFO lines, warning tracebacks) printed amid normal output.Changes
Prepared ...messages end their phase, so clone and--defer-clone-fromspinners stop before items print; failed preparation stops its spinner at once.Failed ...planning messages (cursor watermarks) end their phase as an error line.(7.83s), not((7.83s)).defer_sources_totarget reuses a compiled one. Clone's no-op--no-sql-analysisis accepted but hidden and documented as such.--debug, installed-library records reach the console only at ERROR (full) or WARNING (one line); INFO is hidden. Records logged from project files (hooks, loaders, rules) keep full output.--debugis unchanged.Verification
defer_sources_to, seeds, sources, incrementals, functions and a missing origin, against the previous release.make check-ci.