Skip to content

test: widen the dense fallback CPU ratio guard to 1.10 - #1185

Merged
kvlonge merged 3 commits into
mainfrom
test/fallback-ratio-guard
Oct 21, 2026
Merged

kvlonge merged 3 commits into
mainfrom
test/fallback-ratio-guard

Conversation

@kvlonge

@kvlonge kvlonge commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Why

The dense delta edit-loop guard caps a fallback compile at 1.05x a full compile's median CPU. Across 33 recent passing CI runs the ratio was 0.97–1.04 (median about 1.017): fallback costs about 2% more by design, plus about ±3% runner noise. It failed two unrelated PRs at 1.050 and 1.053.

Changes

  • Raise expected_max_fallback_cpu_ratio from 1.05 to 1.10 for the 3,000- and 10,000-model cases. A fallback that repeats compile work still shows about 2.0x and fails.

Verification

  • Ratios read from the 33 most recent Verify runs' dense compile job logs; none exceeds 1.04.
  • Test-only change; CI runs the guard.

@kvlonge
kvlonge enabled auto-merge (squash) October 21, 2026 00:08
@kvlonge
kvlonge merged commit 1417a1b into main Oct 21, 2026
70 of 72 checks passed
@kvlonge
kvlonge deleted the test/fallback-ratio-guard branch October 21, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant