Repository navigation
docs: give macros an overview of SQL and Python macros, and a Python macros page - #1235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Macros section opened on a page titled "Writing Macros" that described only Python macros, with SQL macros as an aside, even though SQL macros are the simpler default.
Changes
concepts/macrosis now an overview: the two kinds side by side, where they live, how calls name their kind, using them together, where macros work, test-only placement, and choosing between a SQL macro, Python macro, SQL function or audit.concepts/macros/python-macrospage with the Python macro content.Verification