Repository navigation
feat: add sqb review to build, test and compare a branch in a temporary schema - #1238
Merged
Merged
Conversation
Build every changed ancestor of a selected node, send every built node to the review schema in one review database, name review schemas in lowercase, list Python nodes and their SQL readers as not validated, report checks that never ran as incomplete, exit 3 on usage errors, and document hooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Before merging, a branch's changes need building against real data, testing and comparing with production.
sqb test --sinceonly covers unit tests;sqb diffneeds both sides built by hand.Changes
sqb review --since <ref> --against <target>plans the changed nodes plus downstream (--downstream critical|all|none,--select, which always adds changed ancestors);--dry-runstops there and lists hooks.review_<utc>_<sha>_<run>) in one review database, after an append-only ownership marker; upstream is deferred to--against. The schema is always dropped; a failed drop exits 3.critical truemodel key,[review]config, optionalrender_drop_schemaadapter method, and a janitor phase for leftover review schemas.Verification
--select(errors and added ancestors), dry run with hooks, findings, incomplete seeds, Python tasks, own-database nodes, usage errors, setup failures, Markdown failure, cleanup failure with janitor cleanup.make testandmake check-cipass.