Repository navigation
feat: name failed checks in Dagster failures and make Recall runs self-describing - #1256
Merged
Merged
Conversation
…on job and run Invocations record origin (integration, ci or local) and the mode of sqb debug, and the invocations view exposes the integration, job, run and retry from external_context, NULL for older non-JSON rows.
The failure description leads with the failed checks and assets, failure metadata lists the failed checks and counts the selection, and the selection is logged as a count with the full list at debug level.
…as bare columns A plain read of a COLUMNS group stands as one bare column, as expansion pastes it, and every reference to one RELATION parameter as a relation shares one placeholder, so plain single-slot and undeclared reads through it are in scope. Real mixed-qualification and out-of-scope findings beside them are still reported.
kvlonge
enabled auto-merge (squash)
October 26, 2026 03:35
… the previous columns Derive the expected Recall schema version from RECALL_SCHEMA_VERSION, compare the rewritten ClickHouse views with the previous ones over the columns both have, and check the columns the invocations view adds separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A SQLBuild command failing under Dagster did not name the failed audits, the selection flooded the run log and metadata, and failed checks were debug-level events. Recall could not tell a local
sqb debugfrom a failed scheduled run, finding a job's runs meant parsingexternal_context, and an ambiguous ID prefix gave no help.Changes
failed_checksandfailed_check_count.selectionis replaced byselection_countplusselector_file; sensors that readselectionmust switch.invocationsrecordsorigin(integration,cifrom CI variables, orlocal) andcommand_modeforsqb debug. Additive columns, schema version 4, NULL on older rows.invocationsview exposesintegration,integration_job,integration_run_idandintegration_retryon SQLite and ClickHouse; older non-JSON context reads as NULL.@rel.keysgroup read in a SQL macro body no longer trips SQBRSQL028/029; real findings beside it still report.sqb recall schemadescribe all of the above.Verification
not_nullaudit checks the description, metadata, ERROR log and origin; a DuckDB E2E for macro body rules.make test(before the rules fix),make check-ci,make check-e2e-shardsand the hygiene scan pass.