Skip to content

refactor: finish native result and cost reporting boundaries - #1272

Merged
kvlonge merged 1 commit into
mainfrom
refactor/native-result-boundaries
Oct 29, 2026
Merged

kvlonge merged 1 commit into
mainfrom
refactor/native-result-boundaries

Conversation

@kvlonge

@kvlonge kvlonge commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Why

Native orchestration still consumed Python executor objects after execution, and persisted cost reporting unnecessarily started Python. Obsolete migration exports also kept unused production paths alive.

Changes

  • Use typed Rust executor results for build/dbt completion, progress, JSON output, freshness, runtime SQL and integration events while retaining Python-owned interfaces.
  • Share Rust cost storage, selection, exact-decimal sorting and rendering; keep warehouse refresh at the existing adapter edge and never retry output writes through Python.
  • Remove fourteen obsolete exports and exclusively used support; preserve historical parity fixtures and gate legacy analysis batch helpers to tests.
  • Lower crossing budgets without expanding Python stays, warehouse state or public API ownership.

DuckShop additions are not applicable: the regressions concern CLI/result serialization and display, not project shapes, data or warehouse lifecycle behavior.

Verification

  • make test: 12,185 passed before the final dead-binding cleanup.
  • Rebuilt extension/launcher targeted regressions: 227 passed, including seventeen real-launcher cost cases and DuckDB/compiler integration paths.
  • make check-ci, focused Rust analysis/host/cost tests, hygiene and whitespace checks passed.
  • All sixteen original JSON baseline documents are byte-identical; independent review and scoped follow-up found no remaining blockers.
  • Windows, warehouse and full E2E coverage remain CI gates. No live compiler-analysis semantics changed.

Consume typed executor results across reporting and event projections, serve persisted cost reports natively, and remove obsolete migration bindings while preserving Python-owned interfaces.

Amp-Thread-ID: https://ampcode.com/threads/T-01a18715-4e00-708e-a87d-6bd109748d66
@kvlonge
kvlonge enabled auto-merge (squash) October 29, 2026 13:30
@kvlonge
kvlonge disabled auto-merge October 29, 2026 14:06
@kvlonge
kvlonge merged commit 3446a33 into main Oct 29, 2026
44 checks passed
@kvlonge
kvlonge deleted the refactor/native-result-boundaries branch October 29, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant