Repository navigation
fix: match configured snapshot keys and cursors to quoted columns - #1273
Merged
Merged
Conversation
Snapshot required and generated columns, snapshot key exclusion, the microbatch cursor check and merge immutable columns now compare names with the shared column-name key, so a quoted mixed-case name such as '"listingId"' matches its warehouse column on every adapter. A snapshot or microbatch build now stops with a clear error when an unquoted setting names a column the warehouse lists only as a quoted, case-sensitive identifier, instead of failing with a misleading missing-column error or generating SQL for the wrong column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release 0.186.0 matched declared column names to warehouse columns with a shared key that ignores identifier quotes. A few runtime checks still used a plain lower-case comparison. A snapshot keyed on a quoted camelCase column such as
'"listingId"', or a microbatch cursor like'"eventAt"', failed on DuckDB with a misleading "missing required columns" or "cursor not produced" error. On Snowflake, an unquoted name for a case-sensitive column failed the same way, or produced SQL that addressed the upper-cased name.Changes
check_columns [*], the microbatch cursor check, and merge immutable columns (base, DuckDB-backed and Snowflake adapters) use the shared column-name key.QUOTED_IDENTIFIERS_IGNORE_CASEalready accept unquoted names there.Verification
-n 4(392 passed),make test(12,194 passed) andmake check-ci.