Repository navigation
refactor: keep interpreter exit signaling native - #1277
Merged
Merged
Conversation
Replace the private process-wide threading.Event with an atomic flag while preserving existing shutdown hooks, polling, waits and public interfaces. Retire its four Python-crossing allowances and document the existing monotonic process-wide signal. Amp-Thread-ID: https://ampcode.com/threads/T-01a18715-4e00-708e-a87d-6bd109748d66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native shutdown polling should not allocate a Python threading.Event or call Python just to read and set an internal exit flag.
Changes
Verification
make fast-native; its exit signal is a one-byte native symbol.cargo test -p sqlbuild-python --profile fast --lib: 9 passed.make check-ci, including workspace clippy, types, strict-adapter checks and zero fensu faults.