Repository navigation
test(duckshop): edge cases for conversion and analysis findings - #1292
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reviews of SQL conversion and analysis turned up shapes where a Snowflake-to-DuckDB conversion gave a different answer, or where valid Snowflake SQL was reported as an error. DuckShop's edge-case area is where such shapes live as executable examples, with expected values captured on Snowflake, so this adds them there.
Changes
edge__*sources and staging models: basket lines, date and time texts, amount checks, VARIANT attribute values and category links.CONNECT BY, recursive CTEs, joins onUSING);edgesession.MEDIANabove scale 12) are checked by assertions.Verification
sqb compilereports 0 errors and 0 warnings, both with the edge area and on the core copy. The core-copy checksum is unchanged.edgetarget. Two capture runs in a row produced identical files.pytest benchmarks/duckshop/testspasses.ruffformat and lint are clean.make check-cipasses.