Repository navigation
refactor: remove enum variants nothing constructs - #1308
Merged
Merged
Conversation
ConfigErrorKind::Missing and ::InvalidField and SqlFileRole::Yaml are never constructed or matched; XSB077 reported them.
kvlonge
enabled auto-merge (squash)
November 5, 2026 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The new unconstructed-variant rule (XSB077) reports three enum variants on main that nothing constructs or matches:
ConfigErrorKind::Missing,ConfigErrorKind::InvalidFieldandSqlFileRole::Yaml. The config reader stopped producing the first two when the native reader took over, and no discovered-file group has a YAML role.Changes
MissingandInvalidFieldfromConfigErrorKind. The onlymatchon it handlesUnsupportedand routes every other kind through one arm.YamlfromSqlFileRole. The role is built only from Rust-side file groups and is never deserialized, so no input can name it.Verification
cargo test -p sqlbuild-config -p sqlbuild-refactor: passes.fensu checkreports no XSB077 warnings on this branch.make check-cipasses.