Repository navigation
ci: fail on unread control-store state, unconstructed variants and new duplicates - #1310
Merged
Merged
Conversation
…w duplicates XSB076 and XSB077 move from warn to select, so fensu check fails on them; check-ci ran fensu check without --warn, so in warn mode they were never evaluated. Their reasoned allowlists and exceptions stay, and stale or malformed entries remain faults. check-dupes-new now fails on new duplicated code and fails when its base is missing instead of skipping. Verify fetches the base on every event, origin/main for a manual run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three static rules ran in warn mode: XSB076 (unread control-store state), XSB077 (unconstructed variants) and the new-duplicate check.
check-cirunsfensu checkwithout--warn, so the two warn-mode rules were never evaluated at all, and the duplicate check skipped with a warning when its base was missing. All three now fail the build on new code. Current main has 0 XSB076, 0 XSB077 and no new duplicate clusters.Changes
fensu.toml: XSB076 and XSB077 move fromwarntoselect. Their reasoned allowlists and exceptions stay; stale or malformed entries remain faults.Makefile:check-dupes-newfails on new duplicated code, and fails (exit 2) whenDUPES_BASEcannot be resolved instead of skipping.verify.yml: the base is fetched on every event; a manual run usesorigin/main.Verification
make check-cipasses on this branch (fensu check: 0 faults; no new duplicates).check-dupes-new(1 new cluster,scratch_copy.py, base c05b834).fensu checkruns: static checks fail with XSB076sqb_scratch_orders.shipped_noteand XSB077ScratchState::Closed.make check-dupes-new DUPES_BASE=does-not-existexits 2 with an error.