Repository navigation
refactor: own local workers on every platform - #1313
Merged
Merged
Conversation
kvlonge
enabled auto-merge (squash)
November 5, 2026 22:54
The monitor test aged the still-live run's heartbeat to 40 seconds during setup, leaving 5 seconds against the 45-second timeout. A slow runner crossed it before the monitored cycle and saw two unresponsive runs. Aging it to 5 seconds just before the cycle leaves a 40-second margin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Local worker ownership, recovery and stop were compiled only on Linux, macOS and Windows. Every other platform had separate code paths that skipped local workers during recovery and left recovered children unowned. Those paths were never built or tested, and they doubled the number of configurations the worker code had to reason about.
Changes
cfg(any(target_os = "linux", target_os = "macos", windows))gates and theirnot(...)twins from the CLI worker launcher, child handling, recovery and models.sqlbuild-process-ownershipbecomes an unconditional dependency ofsqlbuild-cli.Verification
make check-ci.make test-nativeforsqlbuild-cli,sqlbuild-process-ownershipandsqlbuild-orchestration.