Repository navigation
fix: let Recall's final delivery rows use the remaining shutdown budget - #1325
Merged
Merged
Conversation
The delivery summary rows written when a session closes were capped at 500 ms even when most of shutdown_timeout remained, so one slow hosted store response marked an otherwise fully delivered transcript incomplete. They now get the rest of the shutdown budget, and at least 500 ms; close still returns by the shutdown deadline.
kvlonge
enabled auto-merge (squash)
November 6, 2026 12:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a Recall session closed, its final delivery-summary rows were capped at 500 ms even when most of
shutdown_timeoutremained. A single slow hosted-store response therefore marked a fully delivered transcript incomplete. CI saw this on Windows: every stream was delivered, yet the session reported "Recall delivery deadline expired".Changes
closestill returns by the shutdown deadline, soshutdown_timeoutstill caps the delay at exit, as the docs describe.closehas returned and reported history incomplete. The store, which is the source of truth, is then correct and the CLI under-reports, which is the safe direction.Verification
cargo test -p sqlbuild-recall: 67 passed.test_readstest passes against PostgreSQL.make check-cipass.