Repository navigation
fix: publish audits that share a name as separate snapshot nodes - #1326
Merged
Merged
Conversation
Inline audits compile to their definition name, so two models with the same inline audit gave two snapshot nodes one key and publication failed. Attached audits are now keyed by their execution identity: audit name, target kind, target and column. Singular audits keep their key.
kvlonge
enabled auto-merge (squash)
November 6, 2026 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Publishing a project whose models attach the same inline audit, for example
not_nullon two models, failed withduplicate snapshot node identity. Inline audits compile to their definition name, so every attachment produced the sameaudit:<name>snapshot key. The defaultsqb playgroundproject hits this, so it could not be published to a location.Changes
audit:<name>:<kind>:<target>[:<column>]. This is the same identity build progress and results already use. Singular audits keepaudit:<name>.check:keys;Verification
duplicate snapshot node identity). The playground and the edge case also fail the same way with the 0.191.0 CLI.make check-cipasses.