Repository navigation
test(cli): stop parallel launcher tests from holding the copied forwarder busy - #1339
Merged
Merged
Conversation
…nnot hold it busy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
sqlbuildforwarder tests fail on Linux about one run in nine withText file busy(ETXTBSY), which blocks unrelated pull requests in Native workspace checks. Each test copies the forwarder into a temporary directory withstd::fs::copy, which holds a write handle in the test process. A child forked by a parallel test inherits that handle until it execs, and running the copy in that window fails.Changes
cp, so the write handle lives in a short-lived child that exits before the copy runs and parallel forks never inherit it.std::fs::copy.DuckShop: not applicable. This changes a test helper only; no project shape, data value or lifecycle sequence is involved.
Verification
Text file busybefore the change and 0 of 300 after, alternating base and fixed binaries.make check-ciand the public-repository scan.