Repository navigation
Conversation
…g issues A same-run time ratio cannot see one store round trip per node: that cost is linear. Tests now count the statements each task issues, and the wide listing must read builds 100 nodes per statement: 17 statements for 1,000 nodes and 37 for 3,000 on SQLite and PostgreSQL, 1,008 with one node per statement. The ratio check stays and now guards super-linear growth only.
kvlonge
enabled auto-merge (squash)
November 7, 2026 20:05
Contributor
Author
|
Folded into the single combined sqlbuild PR (D625/D626), which the SQLBuild lane is assembling now and opens once #1377 lands. Branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The wide catalog listing guard compares listing times for 1,000 and 3,000 nodes. A time ratio cannot see one store round trip per node, because that cost is linear: with one node per statement the ratio stayed near 3 and the guard passed. Batching needs a deterministic check.
Changes
querybumps a task-local counter; compiled only undercfg(test)).Verification
cargo test -p sqlbuild-orchestration --lib api::tests::test_catalog_readspasses on SQLite and PostgreSQL: 17 statements for 1,000 nodes and 37 for 3,000 (bounds 18 and 38).NODES_PER_STATEMENT = 1the test fails with 1,008 statements for 1,000 nodes.make check-ciandcargo clippy -p sqlbuild-orchestration --all-targets -D warningspass locally.DuckShop: not applicable; this is a store test guard with no project shape, data value or lifecycle sequence.