Repository navigation
Conversation
The person trigger listing now carries each trigger's newest tick, so the jobs and triggers pages no longer read ticks once per trigger. Pages coalesce change notices into one reload, and the HTTP client shares an in-flight listing between pages that refresh together.
kvlonge
enabled auto-merge (squash)
November 8, 2026 08:13
# Conflicts: # crates/sqlbuild-orchestration/tests/api/test_reads.rs
Contributor
Author
|
Folded into the single combined sqlbuild PR (D625/D626), which the SQLBuild lane is assembling now and opens once #1377 lands. Branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The live pages reload on every change notice, and a running job sends many. On the jobs page, each reload also read one tick list per trigger and fetched the 1,000-run listing more than once. On a small synthetic DuckDB location, one four-node job run (plus the run its sensor started) made the open Jobs page send 227 API requests, each its own authorized store transaction.
Changes
latest_tick), read through the trigger-time index in the listing's transaction, so a list needs no read per trigger. Authorization is unchanged: view on every current node of the target, as for the listing itself.Verification
cargo testfor the HTTP reads test on SQLite and PostgreSQL: the listing carries the newest of two ticks, and a target without ticks listsnull.npm run check,npm test(new client tests: one request for triggers with ticks; shared listings and a fresh read after a write), regenerated control client,make check-ci.