Repository navigation
Conversation
sqlquack main 19c51fa2 carries the Postgres parser work and the train that followed a9dde6a0. sqlquack-syntax-postgres now depends on stacker, which re-resolves a few Windows-only windows-sys edges in the lock.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The native analysis route and the dialect arms need the SQLQuack parsers now on SQLQuack main. Moving the pin in its own PR keeps one place to look if a hash moves.
Do not merge yet. SQLQuack main past 3115fa31 makes the 3,000-model compile-cache job fail until the relation-marker placeholder helper lands in SQLBuild. This PR will be rebased onto that helper's PR and leaves draft once that job passes.
Changes
sqlquack-syntaxandsqlquack-syntax-postgresfrom 4d0c6bc5 to SQLQuack main 19c51fa2.sqlquack-syntax-postgresgains astackerdependency. Cargo re-resolves six Windows-onlywindows-sysdependency edges as a result. Linux and macOS builds are unaffected.Verification
No user-visible change:
make compiler-differential(--goldens check)tests/goldensunchangedcargo test -p sqlbuild-analysis, including the query fingerprint token testspytest tests/unit/src/sqlbuild/compiler/fingerprints