Repository navigation
test(perf): set the dense guard calibration reference below the EPYC 7763's readings - #1398
Merged
Merged
Conversation
…7763's readings The 0.55 s reference sat inside the EPYC 7763's own calibration readings (0.540 s to 0.62 s), so whether a 7763 run got a larger budget depended on noise, while its warm and edit medians sit right at the unscaled budgets. At 0.50 s every 7763 reading scales the budgets by at least 1.08. Classes the budgets fit keep a factor of at most 1.04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The dense 5,000-model guard scales its budgets by the runner calibration's fastest repetition over a reference. The 0.55 s reference sat inside the EPYC 7763's own readings, so 7763 runs got factor 1.0 or slightly more depending on noise. Their warm (about 9.2 s) and edit (about 9.6 s) medians sit right at the unscaled 9.0 s and 9.5 s budgets, so unchanged code passed or failed at random.
Changes
The reference is below 7763's minimum (0.540 s), so every 7763 run now gets at least 1.08: warm 9.72 s and edit 10.26 s against observed medians of 9.18-9.22 s and 9.57-9.60 s. Two 7763 jobs on unchanged compiler code read 0.540-0.587 s, and one failed at factor 1.000 with a warm median of 9.22 s.
The factor over-reads the compile slowdown between classes, which leaves slack and never undershoots. On 8370C the absolute guard could miss a regression of up to about 45%; the same-runner ratio jobs still catch it.
Verification
make check-cipasses.