Repository navigation
fix(deps): pin SQLQuack 0.5.1 and SQLClean 0.8.3 - #1410
Merged
Merged
Conversation
SQLQuack 0.5.1 binds LAG and LEAD with one or two arguments on DuckDB, comma-joined LATERAL subqueries that read an earlier FROM item, and lambdas over aggregates in grouped queries, all of which 0.210.0 rejects. It types DuckDB JSON casts, to_json and AT TIME ZONE outputs, so they prove JSON and TIMESTAMP contract types, and gives a column merged by a set operation its strongest branch's transform kind. SQLClean 0.8.3 is built on the same SQLQuack release, so the lockfile holds one copy of each SQLQuack crate. Six Python-oracle goldens are re-recorded: 127 digest lines only. Restoring the merged set-operation columns' old transform kinds in the new canonical views reproduces every old digest. DuckShop's edge-case area gains LAG and LEAD with one to three arguments, a comma-joined LATERAL over a nested derived table, and untyped and typed FILTER lambdas over ARRAY_AGG in a grouped query. Their expectations are derived by hand and cross-checked in DuckDB, because the Snowflake capture could not run. The DuckDB-only shapes are E2E cases in test_dialect_syntax.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.5.1 binds
LAG/LEADwith one or two arguments on DuckDB, comma-joinedLATERALsubqueries that read an earlier FROM item, and lambdas over aggregates in grouped queries. Released SQLBuild 0.210.0 rejects all three (B102, B004, B230). It also types DuckDB JSON casts,to_jsonandAT TIME ZONE.Changes
e1a583eb); SQLClean moves to 0.8.3 (be41ae20);cargo tree -d --depth 0lists nosqlquack-*orsqlcleanduplicate.LAG/LEADwith one to three arguments, a comma-joinedLATERALover a nested derived table, and untyped and typedFILTERlambdas overARRAY_AGGin a grouped query, with unit tests. Expectations captured on Snowflake (RUNBOOK step 7) match the hand-derived values; the tests pass there.UNNESTin a commaLATERAL,lambda e:, JSON andAT TIME ZONEcontract types) are E2E cases intest_dialect_syntax.py; DuckShop is a Snowflake project.BEGIN_COMMIT_OVERRIDE
fix(compile):
LAGandLEADwith one or two arguments on DuckDB, comma-joinedLATERALsubqueries that read an earlier FROM item, and lambdas in grouped queries compile againfix(compile): DuckDB JSON casts,
to_jsonandAT TIME ZONEoutputs prove their JSON and TIMESTAMP contract typesfix(lineage): a column merged by a set operation takes its strongest branch's transform kind
END_COMMIT_OVERRIDE
Verification
make check-cipasses.