Repository navigation
Conversation
A scheduled build reported a source-freshness skip as finished and then reported the same node as started when the executor reached it. The control API rejects that change, so the worker stopped and every node it had not reached yet ended skipped, including branches independent of the stale source. Workers now never report a start for a node whose outcome is already final.
kvlonge
enabled auto-merge (squash)
November 11, 2026 11:14
Contributor
Author
|
Folded into #1413 so the fixes share one CI run. The branch is kept. |
auto-merge was automatically disabled
November 11, 2026 16:50
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a source fails its freshness check, a scheduled build already reports the blocked models as skipped before execution. The executor still calls the node-start hook for those planner skips, so the worker then reported them as started. The control API rejects a start for a node whose outcome is final ("node change is inconsistent with its current outcome"). The worker stopped, and every node it had not reached ended skipped, including branches independent of the stale source.
Changes
no_changeplanner skips need no separate test. The planner never emits a model SKIP with reasonno_change: its only model skip isdisabled, and blocked models getsource_freshness_errororexternal_upstream_failed. Unchanged models are rebuilt or refreshed. If such an entry ever reached the worker, it would take the same path, completed first and then refused a start.worker_freshness_skip.yml. One stale source has two dependent models; an independent model and a model on a fresh source come after them in execution order.Verification
make check-cipasses.