Repository navigation
Conversation
…cs read A statistics read that timed out halved the shared page limit and rewound to catalog. Finishing catalog reset that limit to the maximum, so statistics retried at full size, timed out again and looped, keeping the warehouse busy. Statistics now has its own page limit: it survives the rewind and returns to the maximum once a statistics scan completes.
kvlonge
enabled auto-merge (squash)
November 11, 2026 12:15
Contributor
Author
|
Folded into #1419 so the location sync fixes share one CI run. The branch is kept. |
auto-merge was automatically disabled
November 11, 2026 17:03
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A code location's warehouse metadata sync could loop forever on a warehouse where reading statistics takes longer than the 30-second page timeout. A timed-out statistics page halved the shared page limit and rewound to catalog. Once catalog finished, the limit reset to the maximum, so statistics retried at full size, timed out again, and kept the warehouse busy without ever completing a sync.
Changes
statistics_limit. It halves on a failed statistics read and survives the rewind through catalog. It returns to the maximum when a statistics scan completes, matching howlimitrecovers for the other kinds.100instead of50), a catalog failure that leaves statistics alone, and recovery after a completed scan.Remaining cost, not addressed here: a warehouse that needs a smaller page goes through the same timeouts again each cycle. Taking statistics reads off the warehouse is the next change.
DuckShop edge case: not applicable. This is location sync paging, not a project shape, data value or build lifecycle.
Verification
cargo test -p sqlbuild-cli --lib location_metadata: passes.make check-ci: passes.