Repository navigation
refactor: read every state table name from sqlbuild-core - #1423
Merged
Merged
Conversation
The microbatch, node result, audit result and janitor event table names were still separate Python literals, and a few Rust paths repeated the table names as strings. Python now imports all ten names from the native module, and Rust uses the sqlbuild-core constants. The microbatch table name no longer round-trips through the Python host table. The SQL Server state table builders share one helper instead of five copies of the same build, strip and wrap steps; their SQL is unchanged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLBuild writes ten warehouse state tables, and
STATE_TABLE_NAMESin sqlbuild-core is meant to be their one list. Four names (microbatches, node results, audit results, janitor events) were still separate Python literals, and several Rust paths repeated table names as strings, so a rename could drift between the executor, the location sync and the janitor.Changes
sqlbuild._native, and their Python definitions are deleted.DuckShop edge case: not applicable. No project shape, data value or lifecycle changes; this only changes where existing names come from.
Verification
make check-cipasses (ruff, ty, fensu, workspace clippy).