Repository navigation
fix(deps): pin SQLClean 0.9.0 and SQLQuack 0.6.0 - #1424
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLClean 0.9.0 lays out clauses, parenthesised groups and windows the way SQLQuack 0.6.0 does, so the two move together. SQLQuack 0.6.0 also gives each output column its expression's byte range, which column lineage source highlighting needs next.
Changes
6e18af66) and every SQLQuack pin to 0.6.0 (8d28aa4c).cargo tree -d --depth 0lists nosqlquack-*orsqlcleanduplicate; no other lockfile entry changes.JOIN LATERAL … ON TRUE, the parse errorExpected an expression after LIMIT, and a bare*now sits at its own position in the rule SQL tree, so a custom rule's unqualified*projection reports the star instead of its enclosing select or call.BEGIN_COMMIT_OVERRIDE
feat(format): lay out clauses, parenthesised groups and windows as SQLClean 0.9.0 does
fix(rules): a custom rule's unqualified
*projection reports the star's own line and columnEND_COMMIT_OVERRIDE
Verification
cargo test -p sqlbuild-rulesand-p sqlbuild-analysis --lib(353 passed); format, rules, lint and rule-engine Python suites; compiler differential with CI's coverage gates (391 projects as expected).make check-cipasses.