Repository navigation
Conversation
SQLQuack 0.8.0 records exact select-item ranges in its strict parsers: an aliased Snowflake item now has a span, and a DuckDB column's span covers its qualifier. The expression-range cases that were strict xfails for that gap now pass, so the xfail and its reason are removed. SQLClean moves to e6ad5fa2, which links the same SQLQuack release; its formatter output is unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.8.0 records exact select-item ranges in its strict parsers. Column expression ranges in the node SQL read were marked as strict xfails until it did: Snowflake gave aliased items no span, and DuckDB's column span left out the qualifier.
Changes
8d28aa4c(0.6.0) to17088bd7(0.8.0), and SQLClean moves from6e18af66toe6ad5fa2, which links the same SQLQuack.Cargo.lockchanges only those packages.No DuckShop case applies: this is a dependency pin, and the expression-range cases already cover the fixed shapes.
Verification
cargo test -p sqlbuild-analysis -p sqlbuild-rules: 355 + 106 pass.make check-cipasses.