Repository navigation
fix: separate audit checks from schema nullability - #718
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A runtime
not_nullaudit verifies data after execution; it does not declare that a model's output schema is non-nullable. Treating the audit as schema metadata caused false K004 diagnostics whenever static analysis correctly proved that the SQL expression could return null.Changes
nullable falsecontract metadata.nullable falsestill fails with K004.Verification
uv run pytest tests/unit/src/sqlbuild/compiler/contracts/test_validate.py tests/integration/src/sqlbuild/cli/commands/main/test_compile.py -n auto --dist loadfileuv run fensu checkuv sync --all-extrasmake check-ci