Repository navigation
fix: accept proven dependency wildcards - #726
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQBRCONTRACT105required a dependency-importSELECT *to be expanded even when every enforced contract type was already proven from the referenced resource. Expanding that import then made the CTE transformational, conflicting withSQBRMODEL101and removing the passthrough exemptions used by the model test/audit Rules.Changes
__ref/__sourcedependency import whose typed contract columns are all provenVerification
cargo test -p sqlbuild-rules-native given_enforced_contract_outputs_when_evaluating_explicit_type_rule_then_returns_expected_faultscargo clippy -p sqlbuild-rules-native --all-targets -- -D warningsuv sync --all-extrasmake check-ciSQBRMODEL101, 99SQBRTEST201, and 100SQBRTEST202conflicts