Repository navigation
fix(planner): avoid duplicate planning work - #750
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Large projects repeated model change detection for optional selection diagnostics and rebuilt project-wide SQL-test indexes for every test case. That work scaled with both project and test counts even when the results were identical.
Changes
Verification
uv run pytest tests/unit/src/sqlbuild/compiler/planner/_helpers/planning/test_identities.py tests/unit/src/sqlbuild/compiler/planner/_helpers/test_selection_staleness.py tests/unit/src/sqlbuild/compiler/planner/_helpers/changes/test_detect.py tests/unit/src/sqlbuild/compiler/planner/_helpers/test_fixture_planning_work.py tests/unit/src/sqlbuild/compiler/planner/_helpers/sql_test_assembly/test_plan_test.py tests/unit/src/sqlbuild/compiler/planner/main/test_execution.py tests/integration/src/sqlbuild/compiler/planner/_helpers/test_fixture_planning.py tests/integration/src/sqlbuild/compiler/planner/main/test_build_execution_plan.py -n auto --dist loadfilemake check-cimake test(6,771 passed)